-
-
Notifications
You must be signed in to change notification settings - Fork 272
Fixing the Navigation is not working in the blog in Japanese #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @Deepak-cell311! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference, kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1642 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @DhairyaMajmudar , |
Closes #1614
What kind of change does this PR introduce?
This PR fixes a bug where in-page navigation (e.g., table of contents or anchor links) was not working in the Japanese version of the blog. The root cause was that the
slugifyMarkdownHeadline
function did not correctly handle non-Latin characters like Japanese, resulting in empty or malformed slugs.Checklist
Closes #1614
@benjagm